feat(bazarr) Adding exportarr to expose metrics to prometheus #14761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobReus
changed the title
|
| GitGuardian id | Secret | Commit | Filename | |
|---|---|---|---|---|
| - | Generic High Entropy Secret | de5156e | charts/stable/bazarr/ci/default-values.yaml | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
RobReus
changed the title
PrivatePuffin
requested changes
Dec 3, 2023
added 4 commits
December 20, 2023 12:58
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
Signed-off-by: Kjeld Schouten <[email protected]>
PrivatePuffin
approved these changes
Dec 20, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds exportarr to the bazarr application as bazarr is supported by exportarr. This allows the user to have prometheus scrape for bazarr metrics.
⚙️ Type of change
🧪 How Has This Been Tested?
Created a personal catalog which I added to TrueNAS. I then installed this app sourced from this catalog to ensure the questions + answers, and actual installation works.
📃 Notes:
Exportarr for bazarr does not work without having the API key to access bazarr set. I have added this as a question to the metrics part (see below screenshot). Is this an acceptable way of doing this, or should it be done differently? Unfortunately bazarr does not support setting the api key via environment variables, so enabling metrics for a new deployment requires 2 deployments. The first one without metrics enabled to bootstrap bazarr, and then a second one to enable metrics and set the api key.
Also, due to a bug in exportarr (onedr0p/exportarr#244), exportarr does not work when there are no series added/sonarr is not configured. Should this be mentioned anywhere to the users of this chart?
✔️ Checklist:
➕ App addition
If this PR is an app addition please make sure you have done the following.
icon.pngPlease don't blindly check all the boxes. Read them and only check those that apply.
Those checkboxes are there for the reviewer to see what is this all about and
the status of this PR with a quick glance.